-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added recipe for bilm #6693
added recipe for bilm #6693
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Does anybody have an idea why this fails on Mac and Linux build but not on Windows? On my local Mac build everything is fine. |
It seems you will need the |
recipes/bilm/meta.yaml
Outdated
sha256: 5722ebd46f4120823469e1c221d4123cc6a1bc33b7083243e0893066e6f5a0f1 | ||
|
||
build: | ||
noarch: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have to remove the noarch
and add a build
section inside of the requirements
and after that add
build:
- {{ compiler('c') }}
This is a 100% pure python package. See here: https://github.com/allenai/bilm-tf |
It seems that tensorflow needs it |
Even the setup.py file is very simpel to build the PyPI package: https://github.com/PhilipMay/bilm-tf/blob/setup.py/setup.py |
Yes TF needs c compiler for sure. But I do not build tensorflow... I am confused. |
probably TF needs the runtime libraries and it's not adding it into the package |
I'm just doing some tests and investigating that if you don't mind |
The Tensorflow build does not add the c runtime https://github.com/conda-forge/tensorflow-feedstock/blob/master/recipe/meta.yaml at run level. But I am sure that c is needed. Should that recipe be changed then? |
Well, now all builds fail. Even the Mac Build. Do you have any idears? |
Yes, maybe. As I don't have experience with TF I will mark @jakirkham and @dougalsutherland they may have a hint here |
If they do not answer you I will take a look on that later |
The |
@jjhelmus Ok - so I have to wait until the tensorflow package is fixed so my build does not fail? |
@jjhelmus Or should I just remove the tests like the tensorflow guys did: |
The windows build has this failure:
I think the reason is that tensorflow is not build for python 2.7 on windows. See here: https://github.com/conda-forge/tensorflow-feedstock/blob/master/recipe/meta.yaml#L10 How do I fix this in case of windows? |
Tensorflow is limited to Python 3.x on Windows. If you require tensorflow at run time you will need to skip the Python 2.7 build on Windows. |
tensorflow # [not (win and py27)] like in the keras package
... so you can decide if you want to use tensorflow-gpu or just tensorflow
I removed the tensorflow dependency so you can decide if you want to use tensorflow-gpu or just tensorflow. Like it has been done in the setup.py of bilm: https://github.com/allenai/bilm-tf/blob/master/setup.py |
Can someone trigger a rebuild please? |
Could you please merge with |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/bilm:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
version: {{ version }} | ||
|
||
source: | ||
# there is no Github release - so this ugly link is needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we know this is version 0.1 if there are no releases?
|
||
build: | ||
number: 0 | ||
script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed --no-cache-dir -vvv" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be noarch: python
?
added recipe for bilm - nothing else to say :-)