Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added recipe for bilm #6693

Closed
wants to merge 12 commits into from
Closed

added recipe for bilm #6693

wants to merge 12 commits into from

Conversation

PhilipMay
Copy link
Member

added recipe for bilm - nothing else to say :-)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bilm) and found it was in an excellent condition.

@PhilipMay
Copy link
Member Author

Does anybody have an idea why this fails on Mac and Linux build but not on Windows? On my local Mac build everything is fine.

@marcelotrevisani
Copy link
Member

It seems you will need the c compiler

sha256: 5722ebd46f4120823469e1c221d4123cc6a1bc33b7083243e0893066e6f5a0f1

build:
noarch: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have to remove the noarch and add a build section inside of the requirements and after that add

  build:
    - {{ compiler('c') }}

@PhilipMay
Copy link
Member Author

This is a 100% pure python package. See here: https://github.com/allenai/bilm-tf
Why do I need a compiler?

@marcelotrevisani
Copy link
Member

It seems that tensorflow needs it

@PhilipMay
Copy link
Member Author

Even the setup.py file is very simpel to build the PyPI package: https://github.com/PhilipMay/bilm-tf/blob/setup.py/setup.py

@PhilipMay
Copy link
Member Author

PhilipMay commented Sep 18, 2018

It seems that tensorflow needs it

Yes TF needs c compiler for sure. But I do not build tensorflow... I am confused.

@marcelotrevisani
Copy link
Member

probably TF needs the runtime libraries and it's not adding it into the package
It may be an error in the build process of TF or it's normal to add this, lets see if the build will pass now

@marcelotrevisani
Copy link
Member

I'm just doing some tests and investigating that if you don't mind

@PhilipMay
Copy link
Member Author

probably TF needs the runtime libraries and it's not adding it into the package
It may be an error in the build process of TF or it's normal to add this, lets see if the build will pass now

The Tensorflow build does not add the c runtime https://github.com/conda-forge/tensorflow-feedstock/blob/master/recipe/meta.yaml at run level. But I am sure that c is needed. Should that recipe be changed then?

@PhilipMay
Copy link
Member Author

Well, now all builds fail. Even the Mac Build. Do you have any idears?

@marcelotrevisani
Copy link
Member

Yes, maybe. As I don't have experience with TF I will mark @jakirkham and @dougalsutherland they may have a hint here

@marcelotrevisani
Copy link
Member

If they do not answer you I will take a look on that later

@jjhelmus
Copy link
Contributor

The tensorflow package in conda-forge is a repack of the wheels provided on PyPI. These wheels do not have the same compatibility as other packages in conda-forge. As such, tensorflow may not import on the build machines. For example, on Linux the wheel supports Ubuntu 16.04 or later and is incompatible with the CentOS 6 docker image used for builds, see conda-forge/tensorflow-feedstock#19, tensorflow/tensorflow#8802. Building from source, conda-forge/tensorflow-feedstock#6 may solve this issue but is challenging.

@PhilipMay
Copy link
Member Author

@jjhelmus Ok - so I have to wait until the tensorflow package is fixed so my build does not fail?

@PhilipMay
Copy link
Member Author

@PhilipMay
Copy link
Member Author

The windows build has this failure:

failed to get install actions, retrying.  exception was: Unsatisfiable dependencies for platform win-64: {'bilm==0.1=py27_0'}
WARNING:conda_build.build:failed to get install actions, retrying.  exception was: Unsatisfiable dependencies for platform win-64: {'bilm==0.1=py27_0'}
Tests failed for bilm-0.1-py27_0.tar.bz2 - moving package to C:\bld\broken
WARNING:conda_build.build:Tests failed for bilm-0.1-py27_0.tar.bz2 - moving package to C:\bld\broken
TESTS FAILED: bilm-0.1-py27_0.tar.bz2

I think the reason is that tensorflow is not build for python 2.7 on windows. See here: https://github.com/conda-forge/tensorflow-feedstock/blob/master/recipe/meta.yaml#L10

How do I fix this in case of windows?

@jjhelmus
Copy link
Contributor

tensorflow is not build for python 2.7 on windows

Tensorflow is limited to Python 3.x on Windows. If you require tensorflow at run time you will need to skip the Python 2.7 build on Windows.

tensorflow     # [not (win and py27)] like in the keras package
... so you can decide if you want to use tensorflow-gpu or just tensorflow
@PhilipMay
Copy link
Member Author

I removed the tensorflow dependency so you can decide if you want to use tensorflow-gpu or just tensorflow. Like it has been done in the setup.py of bilm: https://github.com/allenai/bilm-tf/blob/master/setup.py

@PhilipMay
Copy link
Member Author

Can someone trigger a rebuild please?

@jakirkham
Copy link
Member

Could you please merge with master? A lot has changed with our CI setup since this PR was opened.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/bilm) and found some lint.

Here's what I've got...

For recipes/bilm:

  • The recipe must have some tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bilm) and found it was in an excellent condition.

version: {{ version }}

source:
# there is no Github release - so this ugly link is needed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know this is version 0.1 if there are no releases?


build:
number: 0
script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed --no-cache-dir -vvv"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be noarch: python?

@PhilipMay PhilipMay closed this Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants