-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add osx-arm64 + switch to rattler-build #33
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
|
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
The build passes locally on a MacBook Pro M3 but fails here. I guess it's due to the cross compiling. |
Error: Processing $SRC_DIR
Added file://$SRC_DIR to build tracker '/private/tmp/pip-build-tracker-mcfems6f'
Running setup.py (path:$SRC_DIR/setup.py) egg_info for package from file://$SRC_DIR
Created temporary directory: /private/tmp/pip-pip-egg-info-kx9vnmvx
Preparing metadata (setup.py): started
Running command python setup.py egg_info
Traceback (most recent call last):
File "<string>", line 2, in <module>
File "<pip-setuptools-caller>", line 34, in <module>
File "/Users/runner/miniforge3/conda-bld/xformers_1726074224611/work/setup.py", line 24, in <module>
import torch
File "/Users/runner/miniforge3/conda-bld/xformers_1726074224611/_build_env/venv/lib/python3.11/site-packages/torch/__init__.py", line 238, in <module>
_load_global_deps()
File "/Users/runner/miniforge3/conda-bld/xformers_1726074224611/_build_env/venv/lib/python3.11/site-packages/torch/__init__.py", line 197, in _load_global_deps
raise err
File "/Users/runner/miniforge3/conda-bld/xformers_1726074224611/_build_env/venv/lib/python3.11/site-packages/torch/__init__.py", line 178, in _load_global_deps
ctypes.CDLL(lib_path, mode=ctypes.RTLD_GLOBAL)
File "/Users/runner/miniforge3/conda-bld/xformers_1726074224611/_build_env/lib/python3.11/ctypes/__init__.py", line 376, in __init__
self._handle = _dlopen(self._name, mode)
^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: dlopen(/Users/runner/miniforge3/conda-bld/xformers_1726074224611/_build_env/venv/lib/python3.11/site-packages/torch/lib/libtorch_global_deps.dylib, 0x000A): tried: '/Users/runner/miniforge3/conda-bld/xformers_1726074224611/_build_env/venv/lib/python3.11/site-packages/torch/lib/libtorch_global_deps.dylib' (no such file), '/Users/runner/miniforge3/conda-bld/xformers_1726074224611/_build_env/lib/python3.11/site-packages/torch/lib/libtorch_global_deps.dylib' (no such file)
error: subprocess-exited-with-error |
@conda-forge/xformers I am happy to keep digging here. I tried to look around for this I feel like there is some confusion in between the host and build envs. Also worth noting, the build passes locally on Any idea? Did I miss something obvious here? |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/recipe.yaml: This is a v1 recipe and not yet lintable. We are working on it! |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/recipe.yaml: This is a v1 recipe and not yet lintable. We are working on it! |
A new bug that seems to be due to rattler this time: × error Error building package: Failed to resolve dependencies: Cannot solve the request because of: No candidates were found for __osx >=11.0.
Error: × Failed to resolve dependencies: Cannot solve the request because of: No
│ candidates were found for __osx >=11.0.
│
╰─▶ Cannot solve the request because of: No candidates were found for __osx
>=11.0. |
Seems related to prefix-dev/rattler-build#1052. I wonder whether fixing this would also fix the above cross compilation issue using |
(and yes, using rattler decreases the build duration from ~15 min to ~5 min on osx-64) |
Looking at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1025920&view=logs&jobId=1b8be447-c2bd-5772-b66a-a1146441bf88&j=1b8be447-c2bd-5772-b66a-a1146441bf88&t=0da7bde9-21e8-5d19-f418-738876121ca7, it seems that |
|
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12381265860. Examine the logs at this URL for more detail. |
osx works but osxarm64 fails and it seems related to prefix-dev/rattler-build-conda-compat#56
|
bf3c66e
to
bb23602
Compare
Blocked by prefix-dev/rattler-build-conda-compat#56 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM, thanks. You can of course request to be added to the open-gpu-server, if you'd like (I don't decide, but it makes sense IMO).
Sorry, for the pileup. I thought I'd fix up your commit so we get a CI run going |
Ah ok all good. I let you take over here from now! |
Actually, I think we can try switching this back to azure. The recent runs on the server only took ~30 min (not hours like it used to; for reasons I don't really understand BTW). |
I am fine with that since last time I tried, it worked fine. You do it or I do it? |
This reverts commit 3d003e5.
…cd50fb29, and conda-forge-pinning 2024.12.17.18.56.30
Sorry, was already in the thick of it. ;-) |
I bet the osx-arm64 is a transient error. I think a simple restart should do the job. |
I would have just restarted the build. Since it's one of the fast ones, that would have taken less time (<10min) than now restarting the linux+CUDA jobs that had already run for ~20min. |
Yup sorry for that and the error happens again so not sure what is going on actually:
|
And it didn't even help, because you still have a transient error now (they seem to be common for some reason, see also the logs from the run on the GPU server). In any case, please rebase out the last commit |
@wolfv any idea what could be causing this? I thought it was transient, but it seems not. |
argh, no idea what's going on. Might be network related. It's already pretty late over here so I won't be able to look into it more tonight. We also pushed a new rattler-build release which should at least speed things up and use fewer file handles. It might help, idk! if someone wants to shepherd that release now - it's already on github. |
Happy to help, though there's only a commit, no tag. Perhaps someone forget to push the tags? |
Just made it latest release and the tag should be there. |
Thanks both of you for the help here! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)