xgboost v2.1.2 #195
Merged
xgboost v2.1.2 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nda-forge-pinning 2024.10.24.08.44.27
regro-cf-autotick-bot
requested review from
aldanor,
fhoehle,
hcho3,
jakirkham,
ksangeek,
mfansler and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Looks like this may be applied for us in the archive we use. So try dropping it.
jakirkham
reviewed
Oct 25, 2024
|
Marking as draft while we validate the patch changes |
jakirkham
reviewed
Oct 25, 2024
Comment on lines
110
to
113
| requirements: | ||
| build: | ||
| build: # [build_platform != target_platform] | ||
| - python # [build_platform != target_platform] | ||
| - cross-python_{{ target_platform }} # [build_platform != target_platform] |
There was a problem hiding this comment.
Hiding the requirements/build section completely when unused. Otherwise we see this error
EnvironmentLocationNotFound: Not a conda environment: D:\bld\xgboost-split_1727635034975\_build_env
Note: This appears only on Windows. Also it doesn't appear to affect the build. Still seems better to fix
|
Based on the discussion above ( #195 (comment) ), sounds like this is ready to go |
|
Thanks Hyunsu! 🙏 |
This was referenced Nov 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11495795599 - please use this URL for debugging.