Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condaBasePath when useBundled is false, and there's no pre-existing conda #299

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Fix condaBasePath when useBundled is false, and there's no pre-existing conda #299

merged 2 commits into from
Nov 26, 2023

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Nov 6, 2023

Useful when using setup-miniconda with self-hosted runners without conda installed.

goanpeca
goanpeca requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isuruf why did you remove the code for the mac case?

It seems like this change will break something. Could you confirm 🤔 ?

@isuruf
Copy link
Member Author

isuruf commented Nov 14, 2023

It's the same as path.join(os.homedir(), "miniconda3"); right?

@goanpeca
Copy link
Member

goanpeca commented Nov 14, 2023 •
edited
Loading

It's the same as path.join(os.homedir(), "miniconda3"); right?

I think not, and home dir might have been pointing somewhere else on mac, hence the hardcoded path. Could you please verify before deleting the code?

Thanks

@goanpeca goanpeca marked this pull request as draft November 14, 2023 22:14
@isuruf
Copy link
Member Author

isuruf commented Nov 14, 2023

With macos-latest image it is the home directory.

@isuruf
Copy link
Member Author

isuruf commented Nov 21, 2023

Ping on this

@dbast
Copy link
Member

dbast commented Nov 21, 2023

How about running:

conda create -n github-action nodejs=16 -c conda-forge
conda activate github-action
npm ci
npm run build

and committing the resulting updates so that the example runs actually test the changes proposed by this PR?

@goanpeca goanpeca self-assigned this Nov 26, 2023
@goanpeca goanpeca marked this pull request as ready for review November 26, 2023 19:23
@goanpeca goanpeca requested a review from a team as a code owner November 26, 2023 19:23
@goanpeca goanpeca merged commit d1e04fc into conda-incubator:main Nov 26, 2023
54 checks passed
@isuruf
Copy link
Member Author

isuruf commented Nov 26, 2023

Thanks @goanpeca

@isuruf isuruf deleted the condaBasePath branch November 26, 2023 20:24
@isuruf isuruf mentioned this pull request Nov 26, 2023
Open
18 tasks
jdblischak added a commit to workflowr/workflowr-pkg-tests that referenced this pull request Jan 6, 2025
@jdblischak
Bump conda actions
508033d 
macos-13 doesn't include a bundled conda, which should be fixed
by updating setup-miniconda to v3

conda-incubator/setup-miniconda#344
https://github.com/conda-incubator/setup-miniconda/releases/tag/v3.0.0
conda-incubator/setup-miniconda#299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goanpeca goanpeca goanpeca approved these changes

Assignees

@goanpeca goanpeca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isuruf @goanpeca @dbast