Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic environment marker support to conda skeleton pypi #1984

Merged
merged 2 commits into from
May 3, 2017

Conversation

evhub
Copy link
Contributor

@evhub evhub commented May 2, 2017

Looks for simple environment markers of the form ^:python_version(<|<=|!=|==|>=|>)(.+)$ and adds in their requirements if the current Python version matches the specification. Resolves #1974.

@evhub evhub changed the title Add basic environment marker support to conda skeleton Add basic environment marker support to conda skeleton pypi May 2, 2017
@msarahan
Copy link
Contributor

msarahan commented May 3, 2017

Looks good. Could you please add some tests so that we're actually exercising your addition (mostly to make sure that no one, especially me, breaks your new functionality later). If you need help on how conda-build's tests work, don't hesitate to ask.

@evhub
Copy link
Contributor Author

evhub commented May 3, 2017

@msarahan Test added and passing!

@msarahan
Copy link
Contributor

msarahan commented May 3, 2017

Cool, looks good enough for now. I may rewrite it later to be more of a unit test than an integration test, but this is certainly good for now. Thanks!

@msarahan msarahan merged commit 91dd9e9 into conda:master May 3, 2017
@github-actions
Copy link

github-actions bot commented May 3, 2022

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda skeleton does not support environment markers
2 participants