-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPy fixes #3868
PyPy fixes #3868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a test for the py value change (additional split) and for the noarch change. Please remove the pyXY selector changes.
For the noarch change, I have no idea how to add a test. It would require a python package with a |
You'll probably need to make a simple recipe. You can build it as part of the test. There's a few examples of that, especially around run_exports. They make the tests slower, but it seems like the most stable, reliable way for tests to stay relevant over time (as opposed to building a package now and putting it somewhere). |
LGTM. Thanks for the revisions. |
Can't use python 3.6 in other cases as it might not be available Using the test for run_exports makes sure that there is a python 3.6 available
One test fails that might be related,
@msarahan, have you seen this before? or is this a new failure? |
Do we not really want to use a different run_export type here? Dropping all but the package name? |
@mingwandroid, I don't understand. Are you suggesting a different run_exports scheme ('noarch' in addition to 'weak', 'strong') that would be applied if the package is a dependency of a |
I am. |
@mingwandroid, done. |
@mingwandroid I'm not sure where you were going with this, but please go ahead with your thoughts. I'm fine with this PR now with or without the new run_exports type. |
Great. This is exactly what I meant. |
Tests pass now (except for unrelated test failures) |
Does anyone have any clues about https://dev.azure.com/anaconda-conda/conda-build/_build/results?buildId=239&view=logs&j=134db9d0-24f8-5cb4-e659-1d272ab2ea38&t=1bd5db4d-dc45-5f16-3e1b-4d645fd2ab7c&l=1548 I don't think it's related but I don't see any important differences there myself. |
It seems that one of the packages which the CRAN tests are using was archived. And because of that, you need more options to download it |
Yes, those 2 tests are failing on master too and seems to be an issue with r-rsed being archived. |
ping |
Thanks @marcelotrevisani. Is there a plan for a release? |
Not that I am aware of... :/ |
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
See commit messages for details.