Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPy fixes #3868

Merged
merged 9 commits into from
Feb 20, 2020
Merged

PyPy fixes #3868

merged 9 commits into from
Feb 20, 2020

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Feb 5, 2020

See commit messages for details.

@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 5, 2020
@isuruf isuruf requested a review from msarahan February 5, 2020 02:18
isuruf added a commit to isuruf/conda-build-feedstock that referenced this pull request Feb 5, 2020
conda_build/metadata.py Outdated Show resolved Hide resolved
Copy link
Contributor

@msarahan msarahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test for the py value change (additional split) and for the noarch change. Please remove the pyXY selector changes.

@isuruf
Copy link
Contributor Author

isuruf commented Feb 6, 2020

For the noarch change, I have no idea how to add a test. It would require a python package with a run_exports section. Any ideas?

@msarahan
Copy link
Contributor

msarahan commented Feb 6, 2020

You'll probably need to make a simple recipe. You can build it as part of the test. There's a few examples of that, especially around run_exports. They make the tests slower, but it seems like the most stable, reliable way for tests to stay relevant over time (as opposed to building a package now and putting it somewhere).

@msarahan
Copy link
Contributor

msarahan commented Feb 6, 2020

LGTM. Thanks for the revisions.

Can't use python 3.6 in other cases as it might not be available
Using the test for run_exports makes sure that there is a
python 3.6 available
@isuruf
Copy link
Contributor Author

isuruf commented Feb 6, 2020

One test fails that might be related,
https://dev.azure.com/anaconda-conda/ccafa57b-d4b4-4525-b7e5-575388d7c030/_apis/build/builds/235/logs/115
with,

2020-02-06T20:28:07.5154326Z Traceback (most recent call last):
2020-02-06T20:28:07.5154675Z   File "/tmp/cb/popen-gw0/test_noarch_python_with_tests0/noarch_python_test_package_1581019389295/test_tmp/run_test.py", line 17, in <module>
2020-02-06T20:28:07.5154737Z     assert os.path.isdir(site_packages)
2020-02-06T20:28:07.5154780Z AssertionError

@msarahan, have you seen this before? or is this a new failure?

@mingwandroid
Copy link
Contributor

Do we not really want to use a different run_export type here? Dropping all but the package name?

@isuruf
Copy link
Contributor Author

isuruf commented Feb 7, 2020

@mingwandroid, I don't understand. Are you suggesting a different run_exports scheme ('noarch' in addition to 'weak', 'strong') that would be applied if the package is a dependency of a noarch package?

@mingwandroid
Copy link
Contributor

I am.

@isuruf
Copy link
Contributor Author

isuruf commented Feb 7, 2020

@mingwandroid, done.

@msarahan
Copy link
Contributor

msarahan commented Feb 7, 2020

@mingwandroid I'm not sure where you were going with this, but please go ahead with your thoughts. I'm fine with this PR now with or without the new run_exports type.

@mingwandroid
Copy link
Contributor

Great. This is exactly what I meant.

@isuruf
Copy link
Contributor Author

isuruf commented Feb 10, 2020

Tests pass now (except for unrelated test failures)

@mingwandroid
Copy link
Contributor

Does anyone have any clues about https://dev.azure.com/anaconda-conda/conda-build/_build/results?buildId=239&view=logs&j=134db9d0-24f8-5cb4-e659-1d272ab2ea38&t=1bd5db4d-dc45-5f16-3e1b-4d645fd2ab7c&l=1548

I don't think it's related but I don't see any important differences there myself.

@marcelotrevisani
Copy link
Member

Does anyone have any clues about https://dev.azure.com/anaconda-conda/conda-build/_build/results?buildId=239&view=logs&j=134db9d0-24f8-5cb4-e659-1d272ab2ea38&t=1bd5db4d-dc45-5f16-3e1b-4d645fd2ab7c&l=1548

I don't think it's related but I don't see any important differences there myself.

It seems that one of the packages which the CRAN tests are using was archived. And because of that, you need more options to download it
We might mock those access to the CRAN repo with the current data which they return. After all, those tests are not testing the connection with the cran but the parser itself.

@isuruf
Copy link
Contributor Author

isuruf commented Feb 13, 2020

Yes, those 2 tests are failing on master too and seems to be an issue with r-rsed being archived.

@isuruf
Copy link
Contributor Author

isuruf commented Feb 17, 2020

ping

@marcelotrevisani marcelotrevisani merged commit 2d9bc35 into conda:master Feb 20, 2020
@isuruf isuruf deleted the pypy branch February 20, 2020 17:25
@isuruf
Copy link
Contributor Author

isuruf commented Feb 20, 2020

Thanks @marcelotrevisani. Is there a plan for a release?

@marcelotrevisani
Copy link
Member

Thanks @marcelotrevisani. Is there a plan for a release?

Not that I am aware of... :/
Mike usually generated the releases, I can see with him how to generate it then

@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants