Install downstream packages in correct subdir
#4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
dholth
reviewed
Jan 31, 2023
| pkg_loc = os.path.join(pkg_subdir, os.path.basename(pkg_file)) | ||
| shutil.move(pkg_file, pkg_loc) | ||
| break |
There was a problem hiding this comment.
I think it was missing from before, there's no need to continue processing once we have a valid pkg_loc
kenodegard
commented
Jan 31, 2023
| info = json.loads(Path(pkg_dir, "info", "index.json").read_text()) | ||
| subdir = info["subdir"] | ||
| except (FileNotFoundError, KeyError): | ||
| subdir = m.config.host_subdir |
There was a problem hiding this comment.
I dislike this fallback, what do we do instead? let the errors propagate up?
There was a problem hiding this comment.
old packages don't have subdir IIRC
This was referenced Jan 31, 2023
jezdez
approved these changes
Feb 9, 2023
|
This had missed news and tests :-/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4750
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?