Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use the subdir defined in the package #4832

Merged
merged 3 commits into from
May 4, 2023

Conversation

kenodegard
Copy link
Contributor

Description

Address a second case (conda-build downstream tests) where conda-build is incorrectly downloading packages into the wrong subdir. This was discovered during conda 23.3.0 on conda-forge.

Resolves #4750

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard self-assigned this Mar 28, 2023
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 28, 2023
@jezdez
Copy link
Member

jezdez commented Mar 28, 2023

@isuruf @mbargull do you have concerns about this change?

@kenodegard kenodegard added this to the 3.25.0 milestone Mar 28, 2023
@isuruf
Copy link
Contributor

isuruf commented Mar 28, 2023

Nope. Looks good to me.

Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a news item at least

@dholth
Copy link
Contributor

dholth commented Apr 6, 2023

One place that packages get mixed even though they belong to different subdirs is in ~/miniconda3/pkgs. I've enjoyed running conda-index on that directory to test.

@jezdez jezdez merged commit 778475d into conda:main May 4, 2023
@kenodegard kenodegard deleted the fix-downstream-test-subdir branch May 22, 2023 20:30
@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Downstream tests download to wrong subdir (breaks boa+libsolv>=0.7.23)
5 participants