-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating conda_build.conda_interface
#5222
Changes from all commits
f4db0dc
50846b0
c90eb18
a8a6c62
606c956
e21eb63
5d27d38
0d5b02c
aa4df8e
051993a
63922d0
8d1e071
d9fa624
4e9180d
72df1cb
c2aa957
f8c9b1e
efd79ac
2faec88
b3c6823
60e4a34
c8c9bf7
fab3d1c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
# Copyright (C) 2014 Anaconda, Inc | ||
# SPDX-License-Identifier: BSD-3-Clause | ||
|
||
from .__version__ import __version__ | ||
|
||
__all__ = ["__version__"] | ||
|
@@ -15,3 +16,17 @@ | |
"render", | ||
"skeleton", | ||
] | ||
|
||
# Skip context logic for doc generation since we don't install all dependencies in the CI doc build environment, | ||
# see .readthedocs.yml file | ||
try: | ||
import os | ||
|
||
from conda.base.context import reset_context | ||
|
||
# Disallow softlinks. This avoids a lot of dumb issues, at the potential cost of disk space. | ||
os.environ["CONDA_ALLOW_SOFTLINKS"] = "false" | ||
reset_context() | ||
|
||
except ImportError: | ||
pass | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This code will be run on every import of I would suggest to either
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is supposed to run for ALL imports of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Gotcha, I'd appreciate if we'd not have to handle the special case for the docs here though. Ultimately it's not a huge deal though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue this is a bug and needs to be resolved by installing all dependencies in the Ci doc build environment. Maybe add caching there? Switch to setup-miniconda?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure but that will require that we stop using the RTD pipeline and switch to a custom workflow which is out of scope for this PR