Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"tarslip" check (does not extract outside of base directory) is case sensitive on Windows #42

Closed
2 tasks done
dholth opened this issue Nov 18, 2022 · 0 comments · Fixed by #43
Closed
2 tasks done

"tarslip" check (does not extract outside of base directory) is case sensitive on Windows #42

dholth opened this issue Nov 18, 2022 · 0 comments · Fixed by #43
Assignees
@dholth
Labels
locked

Comments

@dholth
Copy link
Contributor

dholth commented Nov 18, 2022 •
edited
Loading

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

On Windows, if you are in "c:" (lowercase c) you may not be able to extract, as the check wants you to be in "C:" (uppercase C). https://github.com/conda/conda-package-streaming/blob/main/conda_package_streaming/extract.py#L40

Could switch to os.path.commonprefix() e.g. more similar to https://github.com/conda/conda-pack/pull/242/files
@dholth dholth changed the title "tarslip" check (does not extract outside of path) is case sensitive on Windows "tarslip" check (does not extract outside of base directory) is case sensitive on Windows Nov 18, 2022
@dholth dholth mentioned this issue Nov 18, 2022
Merged
@dholth dholth self-assigned this Nov 18, 2022
dholth added a commit that referenced this issue Nov 18, 2022
@dholth
Fix #42 case insensitive tarslip (#43)
b50d2f7 
* improve is-within-destination-directory check
* quote member.name verbatim in error
* version 0.6.1
@github-actions github-actions bot added the locked label Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dholth dholth

Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #42 case insensitive tarslip conda/conda-package-streaming
1 participant
@dholth