store complete size in transmute zstd compressor #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jezdez
reviewed
May 4, 2023
conda_package_streaming/transmute.py
Outdated
Comment on lines
103
to
104
| pkg_dat = pkg_file._file.read() | ||
| pkg_stream.write(pkg_dat) |
There was a problem hiding this comment.
Remind me, does this trigger reading the whole file into memory?
Suggested change
| pkg_dat = pkg_file._file.read() | |
| pkg_stream.write(pkg_dat) | |
| pkg_stream.write(pkg_file._file.read()) |
There was a problem hiding this comment.
We probably need copyfileobj.
dholth
commented
May 4, 2023
jezdez
reviewed
May 5, 2023
jezdez
reviewed
May 5, 2023
jezdez
reviewed
May 5, 2023
jezdez
approved these changes
May 8, 2023
This was referenced May 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #57