-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert test-recipes
into local noarch packages
#12879
Conversation
94bd72a
to
cc9a4d6
Compare
# create a temporary conda-bld | ||
conda_bld_sub = tmp_path / context.subdir | ||
conda_bld_sub.mkdir(exist_ok=True) | ||
tar_bld_path = str(conda_bld_sub / tar_path.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We move the tarball into a temporary directory to avoid polluting subsequent tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Description
In our tests we have a number of test recipes, specifically
tests/test-recipes
. Some of these recipes were built years ago and uploaded to the conda-test channel (e.g. https://anaconda.org/conda-test/b_post_link_package) and the others are built every time the tests runs, e.g.:conda/tests/conftest.py
Lines 21 to 36 in 70aeb74
This is unnecessarily expensive so lets convert the recipes to noarch and add the packages directly to the repo so we don't have to rely on the conda-test channel!
Checklist - did you ...
news
directory (using the template) for the next release's release notes?Add / update outdated documentation?