24.11.x Fixes denylist_channels channel bug 🐛
#14431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial attempt at fixing denylist_channels bug; still needs tests * adding a news file * making sure the validation is applied for each return statement * fixing broken test * adding a new testing module to handle the tests and future tests which must test multiple commands under similar circumstances * suggestions for changes from pull request review * suggestions from pull request review * Apply suggestions from code review Co-authored-by: Jannis Leidel <[email protected]> * more suggestions from pull request review * Update conda/core/index.py Co-authored-by: Ken Odegard <[email protected]> * Move tuple into check_channel_allowlist. * Rename check_channel_allowlist to validate_channels * Rename check_channel_allowlist to validate_channels to better reflect its purpose of validating both allowlist and denylist configurations * Update function to return the validated channels tuple * Update all references in code to use the new name * Update deprecation notice in check_allowlist to reference new name * Fix news entry formatting for consistency Fixes #14405 * Fix lint. * Fix tests. * Minor fix. * The argparse args are an AttrDict and need converting first. --------- Co-authored-by: Jannis Leidel <[email protected]> Co-authored-by: Ken Odegard <[email protected]>
conda-bot
added
the
cla-signed
kenodegard
previously approved these changes
Dec 9, 2024
CodSpeed Performance ReportMerging #14431 will not alter performanceComparing Summary
|
ForgottenProgramme
previously approved these changes
Dec 9, 2024
jezdez
dismissed stale reviews from ForgottenProgramme and kenodegard
The base branch was changed.
travishathaway
approved these changes
Dec 10, 2024
ForgottenProgramme
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #14403
Refs #14405
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?