Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make linter happy and add license-files #1047

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented Feb 5, 2025

Not sure if this helps the version sdist situation.

@baszalmstra
Copy link
Collaborator

I dont like this behavior at all, apparently if there is a LICENSE file the sdist will not include it but will reference it ..

Although I think this method of yours works, it makes the licensing of the project slightly more complicated because now someone has to parse the file instead of being able to refering to an SPDX. Let me try something today.

@baszalmstra
Copy link
Collaborator

If I read PEP 639 correctly we should just be able to use just

license = "BSD-3-Clause"

But this part of the maturin codebase ALWAYS adds the LICENSE.

I think the easiest step for now, is just to remove the LICENSE file on build to not trigger this behavior??

@wolfv
Copy link
Contributor Author

wolfv commented Feb 6, 2025

I copied the code from Ruff. But feel free to change things around :)

@baszalmstra
Copy link
Collaborator

So, my solution is to simply remove the LICENSE file. It serves no purpose since there is one at the repository's root.

@wolfv
Copy link
Contributor Author

wolfv commented Feb 6, 2025

Should we try?

@baszalmstra baszalmstra merged commit dcc0d99 into conda:main Feb 6, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants