-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use python_site_packages_path field when available for installing noarch: python packages, CEP-17 #909
Conversation
The IndexJson and PackageRecord struct include an optional python_site_packages_path field as specified in CEP-17.
When specified in the packages repodata entry, use the "python_site_packages_path" field for the location of the site_packages_path.
This totally seems like the right approach! 👍 |
I took the liberty to continue your work, bring it up to date and add python bindings. |
Its a bit hard to test because there doesnt appear to be a python package yet that has this field set. Im relatively sure that it will work so Im going to go ahead and merge this when CI turns green. If we encounter bugs we can fix them in a seperate PR. |
Thanks much for taking over this change @baszalmstra. There are three test packages in the I checked with the sample packages with valid paths and got the expected result with this change.
|
Awesome! Thanks for testing! |
Description
Use the
python_site_packages_path
field from repodata to set the directory whennoarch: python
packages get installed as specified in CEP-17.This the start of an implementation. Wanted to get feedback on the approach before updating other crates and tests.