Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue: If status-listener throw exception, task not executed #130

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

ghkdwlgns612
Copy link
Contributor

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

Describe the new behavior from this PR, and why it's needed

#58

If an exception occurs in taskStatusListener.onTaskInProgress(), the worker cannot poll, so conductor-server recognizes the task status as IN_PROGRESS.

<worker.log>

ERROR 27230 --- [pool-3-thread-7] c.n.c.client.automator.TaskRunner        : Error polling for taskType: sink-worker, error = 500 :

Describe alternative implementation you have considered

@v1r3n v1r3n merged commit 5425b3f into conductor-oss:main Aug 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants