Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify environment variable usage. #71

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

jmigueprieto
Copy link
Contributor

@jmigueprieto jmigueprieto commented Jan 16, 2025

Changes in this PR

  • Added support for standard env variables: CONDUCTOR_SERVER_URL, CONDUCTOR_AUTH_KEY, CONDUCTOR_AUTH_SECRET.
  • Changes in tests to use the standard variables.
  • Fix DNS related tests.

@jmigueprieto jmigueprieto self-assigned this Jan 16, 2025
@jmigueprieto jmigueprieto marked this pull request as ready for review January 16, 2025 10:40
@jmigueprieto jmigueprieto changed the title Unify environment variable usage. (WIP) Unify environment variable usage. Jan 16, 2025
@jmigueprieto jmigueprieto force-pushed the feature/unify-env-vars branch from eed1369 to 5cdb66c Compare January 16, 2025 12:44
@jmigueprieto jmigueprieto force-pushed the feature/unify-env-vars branch from 5cdb66c to 989d5d5 Compare January 16, 2025 12:49
@jmigueprieto jmigueprieto changed the title (WIP) Unify environment variable usage. Unify environment variable usage. Jan 16, 2025
@jmigueprieto jmigueprieto merged commit 6042c12 into main Jan 16, 2025
3 checks passed
@jmigueprieto jmigueprieto deleted the feature/unify-env-vars branch January 16, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants