Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ability to specify a dynamic URL for destination #23

Merged
merged 8 commits into from
May 2, 2024
Merged

ability to specify a dynamic URL for destination #23

merged 8 commits into from
May 2, 2024

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented Apr 29, 2024 •
edited
Loading

Description

Fixes #19

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner April 29, 2024 21:11
hariso
hariso reviewed May 1, 2024
View reviewed changes
config.go Outdated Show resolved Hide resolved
hariso
hariso reviewed May 1, 2024
View reviewed changes
source_test.go Outdated Show resolved Hide resolved
@maha-hajja maha-hajja requested a review from hariso May 2, 2024 06:35
hariso
hariso reviewed May 2, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
hariso
hariso reviewed May 2, 2024
View reviewed changes
source.go Outdated Show resolved Hide resolved
hariso
hariso approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The comments I left are non-blockers, if you agree with those, I think we can work on them separately.

@maha-hajja maha-hajja merged commit 9f8d048 into main May 2, 2024
3 checks passed
@maha-hajja maha-hajja deleted the maha/dynamic-url branch May 2, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariso hariso hariso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: support dynamic URL
2 participants
@maha-hajja @hariso