[Feat] Refactor config form

* Unify config var
* Separate form validation
* Add class to create the webhooks
* Remove unnecessary validations
* Remove duplicate code

.php-cs-fixer.php

@@ -226,7 +226,8 @@
         'single_line'                         => true,
         'space_before_parenthesis'            => true,
         'inline_constructor_arguments'        => true
-    ]
+    ],
+    'ordered_imports'                             => ['sort_algorithm' => 'alpha']
 
     //'not_operator_with_successor_space'           => false,
     //'no_superfluous_elseif'                       => true,

CHANGELOG.md

@@ -2,7 +2,11 @@
 [Full Changelog](https://github.com/conekta/conekta_prestashop/compare/2.3.5...2.3.6)
 - Add MSI feature by @ElvisHeredia [#115](https://github.com/conekta/conekta_prestashop/pull/115)
 - Fix Coding standards to get approval from Prestashop Validator by @ElvisHeredia [#116](https://github.com/conekta/conekta_prestashop/pull/116)
-
+- Unify config var by @ElvisHeredia [#117](https://github.com/conekta/conekta_prestashop/pull/117)
+- Separate form validation by @ElvisHeredia [#117](https://github.com/conekta/conekta_prestashop/pull/117)
+- Add class to create the webhooks by @ElvisHeredia [#117](https://github.com/conekta/conekta_prestashop/pull/117)
+- Remove unnecessary validations by @ElvisHeredia [#117](https://github.com/conekta/conekta_prestashop/pull/117)
+- Remove duplicate code by @ElvisHeredia [#117](https://github.com/conekta/conekta_prestashop/pull/117)
 
 ## [v2.3.5] - 2022-11-04
 [Full Changelog](https://github.com/conekta/conekta_prestashop/compare/2.3.4...2.3.5)

controllers/front/notifications.php

@@ -1,7 +1,29 @@
 <?php
-
+/**
+ * NOTICE OF LICENSE
+ * Title   : Conekta Card Payment Gateway for Prestashop
+ * Author  : Conekta.io
+ * URL     : https://www.conekta.io/es/docs/plugins/prestashop.
+ * PHP Version 7.0.0
+ * Conekta File Doc Comment
+ *
+ * @author    Conekta <[email protected]>
+ * @copyright 2012-2023 Conekta
+ * @license   http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+ *
+ * @category  Conekta
+ *
+ * @version   GIT: @2.3.6@
+ *
+ * @see       https://conekta.com/
+ */
+require_once dirname(__FILE__) . '/../../model/Database.php';
 class ConektaNotificationsModuleFrontController extends ModuleFrontController
 {
+    public const ORDER_CANCELED = 6;
+
+    public const ORDER_REFUNDED = 7;
+
     public $auth = false;
 
     public $ajax;
@@ -99,7 +121,7 @@ private function orderCanceled($orderID)
     {
         Db::getInstance()->Execute(
             'UPDATE ' . _DB_PREFIX_
-            . 'orders SET current_state = ' . ORDER_CANCELED . ' WHERE id_order = '
+            . 'orders SET current_state = ' . self::ORDER_CANCELED . ' WHERE id_order = '
             . pSQL($orderID)
         );
     }
@@ -113,7 +135,7 @@ private function orderRefunded($orderID)
     {
         Db::getInstance()->Execute(
             'UPDATE ' . _DB_PREFIX_
-            . 'orders SET current_state = ' . ORDER_REFUNDED . ' WHERE id_order = '
+            . 'orders SET current_state = ' . self::ORDER_REFUNDED . ' WHERE id_order = '
             . pSQL($orderID)
         );
     }

lib/conekta-php/lib/Conekta/ConektaObject.php

@@ -105,7 +105,7 @@ public function __toString()
         return $this->__toJSON();
     }
 
-    public function offsetGet($offset)
+    public function offsetGet(mixed $offset): mixed
     {
         return isset($this->_values[$offset]) ? $this->_values[$offset] : null;
     }