-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prestashop 1.7 release #31
Conversation
remove unusefull methods
* Change structure OXXO and SPEI - PS 1.7 * Add config_es - PS 1.7
model implementation
functions over config.php and correct flow in pay methods
* Change structure OXXO and SPEI - PS 1.7 * Add config_es - PS 1.7 * Add model database
* Change structure OXXO and SPEI - PS 1.7 * Add config_es - PS 1.7 * Add model database * Add template payment return * Add model payment card
Feature/card 1.7
* Tokenize card * Refactor - Prestashop Validation report
* Tokenize card * Refactor - Prestashop Validation report * Correction branch
* Tokenize card * Refactor - Prestashop Validation report * Correction branch * Correction branch final
* Correction blank spaces and totals * Correction discount lines * Correction security validator
webhook validation
webhook + pruebas
* unused variable * translation issues
* Add message error in card method and fix static methods * monthly installments
* Add message error in card method and fix static methods * Standards validator prestashop
@@ -2,7 +2,7 @@ | |||
<module> | |||
<name>conekta_prestashop</name> | |||
<displayName><![CDATA[Conekta Prestashop]]></displayName> | |||
<version><![CDATA[2.0.3]]></version> | |||
<version><![CDATA[1.0.0]]></version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is our current version of prestashop 1.7 , was changed from 2.0.3 because this file was taked from prestashop 1.6 repo
@@ -1,139 +0,0 @@ | |||
<?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused form/file
@@ -1,139 +0,0 @@ | |||
<?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused form/file
@@ -26,7 +26,6 @@ | |||
require_once dirname(__FILE__).'/Conekta/Subscription.php'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from here start conekta-php library upgrade into plugin structure, this changes was reviewed in conekta/conekta-php#84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ends at mails/en/conektabanorte.html
conekta_prestashop.php
Outdated
|
||
|
||
if (empty($url)) { | ||
$url = _PS_BASE_URL_ . __PS_BASE_URI__ . "modules/conektaprestashop/webhook/notification.php"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
creo que debe de llevar un _
modules/conektaprestashop/webhook/notification.php
conekta_prestashop
var $city = ""; | ||
var $state = ""; | ||
var $zip = ""; | ||
var $country = ""; | ||
|
||
public function __get($property) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Te sobra un tab aquí
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Estos tabs se arreglaron en el pull request https://github.com/conekta/conekta-php/pull/90/files solo hace falta hacer un pull de esa rama de la libreria aqui en prestashop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eduardoconekta enterado
conekta_prestashop.php
Outdated
); | ||
} | ||
|
||
$webhook = \Conekta\Webhook::create(array_merge(array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esta variable ya no se utiliza más adelante, me parece que la podríamos quitar.
Event signature authentication added
Prestashop1.6 to 1.7 adaptation:
This adaptation have the same features as https://github.com/conekta/conektaprestashop
Additional to it we refactor the code from conektaprestashop.php and distribute: