Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prestashop 1.7 release #31

Merged
merged 33 commits into from
Aug 17, 2017
Merged

Prestashop 1.7 release #31

merged 33 commits into from
Aug 17, 2017

Conversation

edenriquez
Copy link
Contributor

@edenriquez edenriquez commented Aug 8, 2017

Prestashop1.6 to 1.7 adaptation:

This adaptation have the same features as https://github.com/conekta/conektaprestashop

  • Card + MSI
  • Oxxo
  • Spei
  • Webhook validation
  • Admin order display
    Additional to it we refactor the code from conektaprestashop.php and distribute:
  • SQL Queries into model (Database.php)
  • redirection of payment method of current buy to Controller (validation.php)
  • build order parameters into model (Config.php)

Eduardo Enriquez and others added 30 commits July 19, 2017 13:07
* Change structure OXXO and SPEI - PS 1.7

* Add config_es - PS 1.7
functions over config.php and correct flow in pay methods
* Change structure OXXO and SPEI - PS 1.7

* Add config_es - PS 1.7

* Add model database
* Change structure OXXO and SPEI - PS 1.7

* Add config_es - PS 1.7

* Add model database

* Add template payment return

* Add model payment card
* Tokenize card

* Refactor - Prestashop Validation report
* Tokenize card

* Refactor - Prestashop Validation report

* Correction branch
* Tokenize card

* Refactor - Prestashop Validation report

* Correction branch

* Correction branch final
* Correction blank spaces and totals

* Correction discount lines

* Correction security validator
* unused variable

* translation issues
* fixes for bugs with paymenth methods

* anoher fix

* Change vars OXXO and SPEI'

* Feature/card 1.7 (#21)

* unused variable

* translation issues

* translation issues

* msi
* Add message error in card method and fix static methods

* monthly installments
* Add message error in card method and fix static methods

* Standards validator prestashop
@@ -2,7 +2,7 @@
<module>
<name>conekta_prestashop</name>
<displayName><![CDATA[Conekta Prestashop]]></displayName>
<version><![CDATA[2.0.3]]></version>
<version><![CDATA[1.0.0]]></version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is our current version of prestashop 1.7 , was changed from 2.0.3 because this file was taked from prestashop 1.6 repo

@@ -1,139 +0,0 @@
<?php
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused form/file

@@ -1,139 +0,0 @@
<?php
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused form/file

@@ -26,7 +26,6 @@
require_once dirname(__FILE__).'/Conekta/Subscription.php';
Copy link
Contributor Author

@edenriquez edenriquez Aug 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from here start conekta-php library upgrade into plugin structure, this changes was reviewed in conekta/conekta-php#84

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ends at mails/en/conektabanorte.html

@edenriquez edenriquez removed the request for review from andreasantillana August 8, 2017 20:39


if (empty($url)) {
$url = _PS_BASE_URL_ . __PS_BASE_URI__ . "modules/conektaprestashop/webhook/notification.php";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creo que debe de llevar un _ modules/conektaprestashop/webhook/notification.php
conekta_prestashop

var $city = "";
var $state = "";
var $zip = "";
var $country = "";

public function __get($property)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Te sobra un tab aquí

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estos tabs se arreglaron en el pull request https://github.com/conekta/conekta-php/pull/90/files solo hace falta hacer un pull de esa rama de la libreria aqui en prestashop

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eduardoconekta enterado

);
}

$webhook = \Conekta\Webhook::create(array_merge(array(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta variable ya no se utiliza más adelante, me parece que la podríamos quitar.

@edenriquez edenriquez merged commit 8775187 into master Aug 17, 2017
LucianoPSerfe pushed a commit to LucianoPSerfe/conekta_prestashop that referenced this pull request Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants