TypeError: Class constructor Presenter cannot be invoked without 'new'

[hult]

Hi @javve @jede et. al.!

We've been using yayson in ES6 like this

import yayson from 'yayson'
const y = yayson({adapter: 'default'})
const Presenter = y.Presenter

class MyPresenter extends Presenter {
  // ...
}

class AnotherPresenter extends MyPresenter {
  attributes(instance) {
    // We don't want to send the image to the server
    var attrs = super.attributes(instance)
    delete attrs['image']
    return attrs
  }
}
AnotherPresenter.prototype.type = 'another_type'

And it has worked well up until version 2.0.8. Starting in yayson 2.0.9, we get the error

TypeError: Class constructor Presenter cannot be invoked without 'new'

      59 |     delete attrs['image']
      60 |     return attrs
    > 61 |   }
         |    ^
      62 | }

Something has changed. Any ideas?

[jede]

Hm, interesting. 2.0.9 was a veryminor change, there is however an effort to remove CoffeeScript. Maybe try out that branch? #69

[hult]

2.0.9 was a very minor change

Yeah I saw, but 2.0.8 was a while ago, and quite a few dependencies were updated since.

Maybe try out that branch?

Will do!

#69

Nice.

[hult]

(Sorry for not understanding how coffeescript modules work at all. :( )

If I yarn add https://github.com/confetti/yayson.git#decaffeinate, I get the exact same error as above.

If I try to install any commit between 2.0.8 and 2.0.9 (to pinpoint when the error appeared), I instead get the error Cannot find module 'yayson' (I guess it isn't automatically transpiled?)

[jede]

I think there is a release issue that @javve tried to fix with v2.0.10-quickfix, but I'm not sure it worked. Are you running your example in the browser (and in that case are you using webpack or something else?) or in node?

[hult]

This is for the browser, with webpack (4.41.5). 2.0.10-quickfix didn't fix my problem unfortunately.

[hult]

(Also, I'm perfectly happy with 2.0.8, don't work too hard on this. :))

[jede]

This probably has to do with extending non native ES6 classes. Its wierd that it worked pre 2.0.9 though. I think this will be solved in 3.0 when everything will be native classes :) And I really havn't been working hard on this! 😂

[hult]

🥰😍😘❤️ (In my head, you both worked full-time on this since February last year, no matter what you say.)

…

On Fri, 16 Apr 2021 at 13:37, Johannes Edelstam ***@***.***> wrote: This probably has to do with extending non native ES6 classes. Its wierd that it worked pre 2.0.9 though. I think this will be solved in 3.0 when everything will be native classes :) And I really havn't been working hard on this! 😂 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAC3QKG7UOOWPGKFRZBC323TJAOQRANCNFSM4KQI7VOQ> .

[jede]

A brand new 3.0 version is finally out 😅