cdh: move kms crate to cdh module #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
force-pushed
the
mkulke/rework-kms-crate-as-cdh-module
branch
3 times, most recently
from
4cf1fdb to
7ee0c6e
Compare
the kms crate is used exclusively by cdh, so we don't need to maintain it as individua crate, which helps with naming conflicts and reduces build complexity. Signed-off-by: Magnus Kulke <[email protected]>
mkulke
force-pushed
the
mkulke/rework-kms-crate-as-cdh-module
branch
from
7ee0c6e to
5481884
Compare
|
Oh. Now KBS imports kms as a dependency here as backend impl of KBS. Now if we want to import the denpendency in trustee we need to use So probably we'd better move kms crate out to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the kms crate is used exclusively by cdh, so we don't need to maintain it as individual crate, which helps with naming conflicts and reduces build complexity.
note: this currently builds on pr #814