Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't restrict the alias pattern match groups' order #25

Merged
merged 1 commit into from
May 28, 2024
Merged

Don't restrict the alias pattern match groups' order #25

merged 1 commit into from
May 28, 2024

Conversation

z4kn4fein
Copy link
Member

Describe the purpose of your pull request

This PR fixes the bug where the strict order of the alias pattern match groups disallowed to do the following:

configcat scan <dir> --alias-patterns "wrapper\.get_value\(CC_KEY\)\.then\((\w+) =>"

Related issues (only if applicable)

n/a

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@z4kn4fein z4kn4fein requested a review from a team as a code owner May 27, 2024 15:09
@z4kn4fein z4kn4fein merged commit 27999a8 into main May 28, 2024
31 checks passed
@z4kn4fein z4kn4fein deleted the alias-match-group-fix branch May 28, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laliconfigcat laliconfigcat laliconfigcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z4kn4fein @laliconfigcat