Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configChanged event hook has being triggered inconditionally #81

Closed
Willliamm opened this issue Jul 6, 2023 · 3 comments
Closed

configChanged event hook has being triggered inconditionally #81

Willliamm opened this issue Jul 6, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Willliamm
Copy link

After upgrading to v8.0.*, the configChanged has been triggered every time, regardless of config changes.

This is my implementation:

configCatClient = getClient(featureFlagSettings.Key, PollingMode.AutoPoll, {
	pollIntervalSeconds: 5,
});

configCatClient.on('configChanged', () => {
	document.dispatchEvent(new CustomEvent('feature-flag-keys-updated'));
});
@Willliamm Willliamm added the bug Something isn't working label Jul 6, 2023
@z4kn4fein
Copy link
Member

Hi @Willliamm, thank you for the report! I'll look into this.

@z4kn4fein
Copy link
Member

Hi @Willliamm, I've released v8.0.2 with the fix. Could you please verify that the issue no longer exists on your end? Thanks!

@Willliamm
Copy link
Author

Hey @z4kn4fein, good news! The problem's all sorted out now. Thanks for getting back to us so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants