Fix always firing onConfigChanged hook #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
This PR fixes an issue that the
configChanged
hook is emitted in browser environments even when the downloaded config JSON isn't changed.Part of the issue is that we get
200
response from the browser even when the server responds with304
due to theCache-Control: max-age=0, must revalidate
header we introduced to bypass unnecessaryOPTIONS
requests.Related issues (only if applicable)
JS-SDK issue
Requirement checklist (only if applicable)