Use tgrade custom in valset #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
previously approved these changes
Sep 29, 2021
| @@ -41,5 +41,7 @@ cosmwasm-schema = { version = "1.0.0-soon" } | |||
| cw-multi-test = { version = "=0.10.0-soon3" } | |||
| tg4-engagement = { path = "../tg4-engagement", version = "0.4.0" } | |||
| tg4-stake = { path = "../tg4-stake", version = "0.4.0" } | |||
| # we enable multitest feature only for tests | |||
Comment on lines
1527
to
1530
| suite.app().update_block(|block| { | ||
| block.height += 20; | ||
| block.time = block.time.plus_seconds(100); | ||
| }); |
There was a problem hiding this comment.
I think this 5s/block ratio should be somehow/somewhere standarized (some constant in utils to calculate?).
I see it from time to time, but without context it may be weird to see that you increment height by seemingly arbitral 20.
There was a problem hiding this comment.
Yes, it is semi-codified here: https://github.com/CosmWasm/cw-plus/blob/main/packages/multi-test/src/app.rs#L23-L26
and based on typical block times on Cosmos chains. It would be good to make this a const
ethanfrey
force-pushed
the
use-tgrade-custom-in-valset
branch
from
1c12949 to
2c536e3
Compare
|
One more fix for your comment on magic block times |
ueco-jb
approved these changes
Sep 29, 2021
| block.height += 20; | ||
| block.time = block.time.plus_seconds(100); | ||
| }); | ||
| suite.app().advance_seconds(100); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #180
This does a proper suite setup to use the Tgrade app, and register privileged contracts.
Does proper begin/end block calls to act like a real runtime.