Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal branch] Move testhelpers' code to _test.go file #1077

Merged
merged 5 commits into from
Oct 10, 2023
Merged

[internal branch] Move testhelpers' code to _test.go file #1077

merged 5 commits into from
Oct 10, 2023

Conversation

milindl
Copy link
Contributor

@milindl milindl commented Oct 10, 2023

Internal branch for running CI for PR #1049.

Adds a changelog entry.

@milindl milindl mentioned this pull request Oct 10, 2023
Closed
anchitj
anchitj approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milindl milindl merged commit a88e0f3 into master Oct 10, 2023
@milindl milindl deleted the dev_remove_test_code_from_non_test_files branch October 10, 2023 10:44
@milindl milindl mentioned this pull request Oct 10, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anchitj anchitj anchitj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milindl @anchitj @dmlambea