Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated go version to 1.21 and testcontainers-go dependency to v0.27.0 #1125

Closed
wants to merge 0 commits into from

Conversation

rzeijde
Copy link
Contributor

@rzeijde rzeijde commented Jan 5, 2024

No description provided.

Copy link

cla-assistant bot commented Jan 5, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jan 5, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


rzeijde seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rzeijde rzeijde force-pushed the master branch 2 times, most recently from 496657d to a90d047 Compare January 5, 2024 07:02
@milindl
Copy link
Contributor

milindl commented Feb 9, 2024

Thanks for this change @rzeijde . However, is it possible to just update the testcontainers-go dependency for now and not update the go version? Even though the language version is out of support, we will still support 1.17 for as long as we can.

@rzeijde
Copy link
Contributor Author

rzeijde commented Feb 9, 2024

unfortunately the test container dep is causing the golang version update.
github.com/testcontainers/testcontainers-go/modules/compose v0.27.0 requires golang 1.21 😿

@milindl
Copy link
Contributor

milindl commented Feb 12, 2024

@rzeijde , sorry for closing this PR. I just wanted to add changes to the CHANGELOG.md and README.md, and I accidentally pushed from the wrong branch. Now that it's been pushed to from wrong branch, the PR is autoclosed and I no longer have the permission to push to rzeijde:master anymore to fix the issue.

These are the changes. They add your name to CHANGELOG, and information about the new version to README: 75c5b2a
If you want you can cherry-pick them and reopen the PR or else I can merge them separately.

Thanks

@rzeijde
Copy link
Contributor Author

rzeijde commented Feb 13, 2024

@milindl will take a look at it sat/sun.

@rzeijde
Copy link
Contributor Author

rzeijde commented Feb 19, 2024

#1136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants