Support transforming maps in Data Contract rules #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
airlock-confluentinc
bot
force-pushed
the
map-in-rules
branch
from
5f4ea81 to
25a0fd5
Compare
kcorman0
reviewed
Oct 28, 2024
| @@ -238,6 +255,9 @@ func disjoint(slice1 []string, map1 map[string]bool) bool { | |||
| } | |||
|
|
|||
| func getField(msg *reflect.Value, name string) (*reflect.Value, error) { | |||
| if msg.Kind() != reflect.Struct { | |||
| return nil, fmt.Errorf("message is not a struct") | |||
There was a problem hiding this comment.
why not do the same thing as above
val.MapIndex(reflect.ValueOf(propName)
There was a problem hiding this comment.
Good question. This method is only for operating on Structs
kcorman0
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support transforming maps in Data Contract rules. Previously only transforming fields in structs were supported. This PR adds ability to transform entries in maps.