Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare v1.3.0 release. #412

Merged
merged 3 commits into from
Dec 16, 2019
Merged

Prepare v1.3.0 release. #412

merged 3 commits into from
Dec 16, 2019
+202 −120

Conversation

rigelbm
Copy link
Contributor

@rigelbm rigelbm commented Dec 16, 2019

I had to adapt the doc-gen.py script, since godoc does not work properly with Go Modules (golang/go#26827).

@rigelbm rigelbm requested a review from edenhill December 16, 2019 14:03
edenhill
edenhill suggested changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@edenhill edenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update README and in-code dependencies to librdkafka v1.3.0 since the Go client relies on new error codes (I missed this last time we had this discussion).

@rigelbm
Copy link
Contributor Author

rigelbm commented Dec 16, 2019

Need to update README and in-code dependencies to librdkafka v1.3.0 since the Go client relies on new error codes (I missed this last time we had this discussion).

Done.

@rigelbm rigelbm requested a review from edenhill December 16, 2019 15:30
@rigelbm rigelbm merged commit 53193a4 into confluentinc:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edenhill edenhill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rigelbm @edenhill