Skip to content

Commit

Permalink
Default resource label prefix to blank - Backward Compatibility (#16)
Browse files Browse the repository at this point in the history
  • Loading branch information
apoorvmittal10 authored and m-ghazanfar committed May 29, 2023
1 parent b7dfb1d commit c8fd92f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public class OpenCensusProtobufInputRowParser implements ByteBufferInputRowParse
private static final String DEFAULT_METRIC_DIMENSION = "name";
private static final String VALUE = "value";
private static final String TIMESTAMP_COLUMN = "timestamp";
private static final String DEFAULT_RESOURCE_PREFIX = "resource.";
private static final String DEFAULT_RESOURCE_PREFIX = "";
private final ParseSpec parseSpec;
private final List<String> dimensions;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -322,13 +322,13 @@ public void testDefaultPrefix() throws Exception
Assert.assertEquals(4, row.getDimensions().size());
assertDimensionEquals(row, "name", "metric_summary-count");
assertDimensionEquals(row, "foo_key", "foo_value");
assertDimensionEquals(row, "resource.env_key", "env_val");
assertDimensionEquals(row, "env_key", "env_val");

row = rows.get(1);
Assert.assertEquals(4, row.getDimensions().size());
assertDimensionEquals(row, "name", "metric_summary-sum");
assertDimensionEquals(row, "foo_key", "foo_value");
assertDimensionEquals(row, "resource.env_key", "env_val");
assertDimensionEquals(row, "env_key", "env_val");
}

@Test
Expand Down

0 comments on commit c8fd92f

Please sign in to comment.