[METRICS-3631] Added compile phases before checks #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanVan
changed the title
xvrl
reviewed
Sep 14, 2021
.semaphore/semaphore.yml
Outdated
| @@ -62,6 +63,7 @@ blocks: | |||
|
|
|||
| - name: "forbidden api checks" | |||
| commands: | |||
| - ${MVN} compile ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS} | |||
There was a problem hiding this comment.
why not test-compile here as well since we also check test code below?
xvrl
approved these changes
Sep 14, 2021
airlock-confluentinc bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
* Use camelCase * Remove comment
pagrawal10
added a commit
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add compile(test-compile) phase before run checks, because semaphore
cache storecommand caches onlytargetfolder of druid directory, nottargetfolders of each directories.Key changed/added classes in this PR
forbiddenapicheckanimal sniffercheck