Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "AVRO_SCHEMA_ID" to "SCHEMA_ID" #4556

Closed
agavra opened this issue Feb 13, 2020 · 1 comment · Fixed by #4651
Closed

rename "AVRO_SCHEMA_ID" to "SCHEMA_ID" #4556

agavra opened this issue Feb 13, 2020 · 1 comment · Fixed by #4651

Comments

@agavra
Copy link
Contributor

agavra commented Feb 13, 2020

Now that schema registry supports types beyond just AVRO (and also pluggable types) it makes sense to rename AVRO_SCHEMA_ID to SCHEMA_ID so that we don't get things like:

ksql> CREATE STREAM json WITH(KAFKA_TOPIC='json', VALUE_FORMAT='json');
ksql> DESCRIBE EXTENDED JSON;

Name                 : JSON
Type                 : STREAM
Key field            :
Timestamp field      : Not set - using <ROWTIME>
Key format           : KAFKA
Value format         : JSON
Kafka topic          : json (partitions: 1, replication: 1)
Statement            : CREATE STREAM JSON (F1 STRING) WITH (AVRO_SCHEMA_ID=2, KAFKA_TOPIC='json', VALUE_FORMAT='json');

 Field   | Type
-------------------------------------
 ROWTIME | BIGINT           (system)
 ROWKEY  | VARCHAR(STRING)  (system)
 F1      | VARCHAR(STRING)
-------------------------------------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants