Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tie up some loose ends around the new formats #4651

Merged
merged 3 commits into from
Mar 2, 2020
Merged

chore: tie up some loose ends around the new formats #4651

merged 3 commits into from
Mar 2, 2020

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Feb 26, 2020

Description

Ties up various loose ends in the new format supports:

  • fixes rename "AVRO_SCHEMA_ID" to "SCHEMA_ID" #4556
  • updates TopicDescription output (is this used???)
  • renames some methods that claimed to be specific to avro
  • TopicDeleteInjector will now also delete non-avro topics
  • Replaces usage of KafkaAvroSerializerConfig with AbstractKafkaSchemaSerDeConfig when relevant
  • ClusterTerminator now properly cleans up schemas for non-avro topics

Testing done

  • Added unit tests were applicable.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates
Copy link
Contributor

Something else to consider including: #4656

@agavra
Copy link
Contributor Author

agavra commented Feb 28, 2020

@big-andy-coates that one is actually a little less trivial than the others, so I'm going to have a separate PR to address #4656

@agavra agavra changed the base branch from master to 5.5.x March 2, 2020 21:24
@agavra agavra marked this pull request as ready for review March 2, 2020 21:46
@agavra agavra requested a review from a team as a code owner March 2, 2020 21:46
@vpapavas vpapavas self-assigned this Mar 2, 2020
vpapavas
vpapavas approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@vpapavas vpapavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Thank you @agavra !

@agavra agavra merged commit 43db241 into confluentinc:5.5.x Mar 2, 2020
@agavra agavra deleted the infer_misc branch March 2, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpapavas vpapavas vpapavas approved these changes

Assignees

@vpapavas vpapavas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename "AVRO_SCHEMA_ID" to "SCHEMA_ID"
3 participants
@agavra @big-andy-coates @vpapavas