Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JLine version to 3.11.0 #2734

Merged
merged 1 commit into from
May 7, 2019
Merged

Conversation

ouertani
Copy link
Contributor

Description

Fixes #2350 -> upgrade the jLine version

Testing done

Manual testing

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@ouertani ouertani requested a review from a team as a code owner April 25, 2019 10:21
@ghost
Copy link

ghost commented Apr 25, 2019

@confluentinc It looks like @ouertani just signed our Contributor License Agreement. 👍

Always at your service,

clabot

Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this fix in this PR https://github.com/confluentinc/ksql/pull/2730/files
Which one would you update?

@ouertani
Copy link
Contributor Author

@spena this one first as to keep the history log the second one target a different issue.

Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spena spena changed the title Fixes #2350 Tab in multi-line input causes org.jline.reader.EOFErro Upgrade JLine version to 3.11.0 May 7, 2019
@spena spena merged commit ecf7165 into confluentinc:master May 7, 2019
@ouertani ouertani deleted the KSQL-2350 branch June 18, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab in multi-line input causes org.jline.reader.EOFError
2 participants