Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logicalSchema toString() to include key fields (MINOR) #3123

Merged
merged 1 commit into from
Jul 24, 2019
Merged

fix: logicalSchema toString() to include key fields (MINOR) #3123

merged 1 commit into from
Jul 24, 2019

Conversation

big-andy-coates
Copy link
Contributor

Description

Noticed this was missing when working on the new field type. This PR adds the key fields to the LogicalSchema.toString output. This will soon be important as the type of ROWKEY may be different.

Testing done

Usual.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates big-andy-coates requested a review from a team as a code owner July 24, 2019 15:10
spena
spena approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spena spena requested a review from a team July 24, 2019 15:13
@big-andy-coates big-andy-coates merged commit 0984529 into confluentinc:master Jul 24, 2019
@big-andy-coates big-andy-coates deleted the logical_key_in_tostring branch July 24, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spena spena spena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@big-andy-coates @spena