feat: add offset to QueuedCommand and flag to Command #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenpyzhang
changed the title
2 tasks
stevenpyzhang
force-pushed
the
add-offset-to-Commands-and-QueuedCommands
branch
from
96df4a4 to
9c7f004
Compare
agavra
approved these changes
Sep 13, 2019
There was a problem hiding this comment.
LGTM! Some nits inline. Also make sure that if for some weird reason we don't get to merge the queryID follow up before 5.4 that this is reverted - otherwise we'd be in a state the flag could be true but the commands are actually still using the old queryID generation!
| @JsonProperty("streamsProperties") final Map<String, Object> overwriteProperties, | ||
| @JsonProperty("originalProperties") final Map<String, String> originalProperties) { | ||
| this.statement = statement; | ||
| this.isNewQueryIdGeneration = |
There was a problem hiding this comment.
you could just do this.isNewQueryIdGeneration = (isNewQueryIdGeneration != null) but I suppose that's a little tricky icky icky 😄
ksql-rest-app/src/test/java/io/confluent/ksql/rest/server/computation/CommandStoreTest.java
Outdated
Show resolved
Hide resolved
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/computation/Command.java
Outdated
Show resolved
Hide resolved
stevenpyzhang
force-pushed
the
add-offset-to-Commands-and-QueuedCommands
branch
2 times, most recently
from
9fe09aa to
4cdd5ff
Compare
stevenpyzhang
force-pushed
the
add-offset-to-Commands-and-QueuedCommands
branch
from
4cdd5ff to
c33f56c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking down the PR at #3330 into smaller pieces, this one focuses on the simpler task of adding new offset values and flags to the command objects. Validation will be done at a later date after more offline discussion. This PR is a precursor to updating the query id generating code for interactive mode.
The flag in Command is to indicate whether or not a command should use the old query id generation or use the new offset based query id. This is needed to ensure that if a server is relying on a command topic with old commands, the old commands will still follow the same pattern for query id generation and query ids are maintained if the server needs to restore.
The field in QueuedCommand represents the offset that the command was read from, it's assigned from the corresponding Kafka ConsumerRecord.offset()
Testing done
Local tests
Deserialization test for new Command
Update existing unit tests
Reviewer checklist