refactor: nicer spec for aggregation steps #4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agavra
approved these changes
Dec 10, 2019
This patch cleans up the aggregation step to specify a list of non-aggregate column references instead of a count of non-aggregate columns.
rodesai
force-pushed
the
clean-up-aggregate-step-nonfunc-column-count
branch
from
9e47cae to
cabb0a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch cleans up the aggregation step to specify a list of
non-aggregate column references instead of a count of non-aggregate
columns.
Part of the work to get us on the schema in #3969