docs: fix docker image names + remove monitoring interceptor docs #4076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimGalasyn
approved these changes
Dec 6, 2019
mikebin
reviewed
Dec 7, 2019
| @@ -114,7 +114,7 @@ Start the ksqlDB CLI: | |||
|
|
|||
| ```bash | |||
| docker run --network tutorials_default --rm --interactive --tty \ | |||
| confluentinc/cp-ksql-cli:{{ site.release }} \ | |||
| confluentinc/ksqldb-cli:{{ site.release }} \ | |||
There was a problem hiding this comment.
Is the ksql command also needed here before the server endpoint? For example:
docker run --network tutorials_default --rm --interactive --tty \
confluentinc/ksqldb-cli:0.6.0 ksql http://ksqldb-server:8088
mikebin
reviewed
Dec 9, 2019
| @@ -166,7 +166,7 @@ Load the Streaming Data to KSQL | |||
| 1. Launch the KSQL CLI: | |||
|
|
|||
| ```bash | |||
| docker-compose exec ksql-cli ksql http://ksql-server:8088 | |||
| docker-compose exec ksql-cli ksql http://ksqldb-server:8088 | |||
There was a problem hiding this comment.
I think it's correct, that's the server endpoint the CLI connects to.
There was a problem hiding this comment.
Jim is correct, the service is named ksql-cli in the docker-compose: https://github.com/confluentinc/examples/blob/5.3.1-post/clickstream/docker-compose.yml#L97 so that part is fine. However, ksqldb-server:8088 should be ksql-server:8088 so Mike has still found a bug! Will update accordingly.
There was a problem hiding this comment.
Ah, my bad. This example is using the CP Docker images, and the containers have the ksql name instead of ksqldb. Sorry for the confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two docs changes:
cp-ksql-serverandcp-ksql-clidocker images toksqldb-serverandksqldb-cliinstead, ascp-ksql-server:0.6.0andcp-ksql-cli:0.6.0don't existTesting done
Docs-only change.
Reviewer checklist