feat: add COUNT_DISTINCT and allow generics in UDAFs #4150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
COUNT_DISTINCT
to the ksqlDB UDAF suite with the following limitations:COUNT(DISTINCT <expr>)
because we don't have support for this type of syntax yetAlso while making this change it looks like it was unnecessary to artificially restrict our UDAF framework from using generics.
Testing done
Reviewer checklist