Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error when column does not exist during INSERT INTO #4926

Merged
merged 1 commit into from
Mar 31, 2020
Merged

fix: throw error when column does not exist during INSERT INTO #4926

merged 1 commit into from
Mar 31, 2020

Conversation

brianstrauch
Copy link
Member

Description

When using INSERT INTO with a nonexistent column, return a helpful error message instead of null.

ksql> CREATE STREAM test_stream (x VARCHAR, y INTEGER) WITH (kafka_topic='test_topic', key='x', value_format='json', partitions=1);
ksql> INSERT INTO test_stream (x, nonexistent) VALUES ('x', 0);
Failed to insert values into 'TEST_STREAM'. Column name `NONEXISTENT` does not exist.

Fixes #3838
Fixes #4253

Testing done

Wrote new unit test

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@brianstrauch brianstrauch requested a review from a team as a code owner March 29, 2020 16:24
@ghost
Copy link

ghost commented Mar 29, 2020

It looks like @brianstrauch hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@brianstrauch
Copy link
Member Author

[clabot:check]

@ghost
Copy link

ghost commented Mar 29, 2020

@confluentinc It looks like @brianstrauch just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@agavra agavra self-assigned this Mar 31, 2020
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @brianstrauch - nice fix :)

@agavra agavra merged commit 89e261d into confluentinc:master Mar 31, 2020
@brianstrauch brianstrauch deleted the insert-into-nonexistent-col branch March 31, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants