Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: output valid multiline queries when running SHOW QUERIES #4956

Merged
merged 1 commit into from
Apr 2, 2020
Merged

fix: output valid multiline queries when running SHOW QUERIES #4956

merged 1 commit into from
Apr 2, 2020

Conversation

brianstrauch
Copy link
Member

Description

Format multiline queries correctly when running SHOW QUERIES.

ksql> CREATE STREAM S3 AS
SELECT * FROM S1
EMIT CHANGES;

ksql> SHOW QUERIES;
Query ID   | Status  | Sink Name | Sink Kafka Topic | Query String
CSAS_S2_73 | RUNNING | S2        | S2               | CREATE STREAM S2 WITH (KAFKA_TOPIC='S2', PARTITIONS=2, REPLICAS=1) AS SELECT * FROM S1 S1 EMIT CHANGES;

Fixes #4900

Testing done

Wrote new unit tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@brianstrauch brianstrauch requested a review from a team as a code owner April 1, 2020 16:27
@ghost
Copy link

ghost commented Apr 1, 2020

@confluentinc It looks like @brianstrauch just signed our Contributor License Agreement. 👍

Always at your service,

clabot

Copy link
Contributor

@big-andy-coates big-andy-coates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant. Thanks @brianstrauch. Appreciate your contribution.

@big-andy-coates big-andy-coates merged commit ec74a33 into confluentinc:master Apr 2, 2020
@brianstrauch brianstrauch deleted the format-show-queries branch April 10, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query String line breaks not rendered correctly
2 participants