Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move Cors handler in front of /chc handlers #5239

Merged
merged 2 commits into from
Apr 30, 2020
Merged

fix: Move Cors handler in front of /chc handlers #5239

merged 2 commits into from
Apr 30, 2020

Conversation

purplefox
Copy link
Contributor

Description

/chc/* endpoints need to be accessible from a browser which will enforce the cross origin policy, so we need cors handler in front of it to provide the cors headers.

Testing done

Manual testing

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@purplefox purplefox requested a review from a team as a code owner April 30, 2020 14:59
@purplefox purplefox requested a review from spena April 30, 2020 14:59
@spena spena added this to the 0.9.0 milestone Apr 30, 2020
spena
spena approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@purplefox purplefox merged commit 004ced2 into confluentinc:master Apr 30, 2020
spena pushed a commit that referenced this pull request Apr 30, 2020
@purplefox @spena
fix: Move Cors handler in front of /chc handlers (#5239)
ba03884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spena spena spena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@purplefox @spena