Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose Vert.x metrics #5340

Merged
merged 7 commits into from
May 21, 2020
Merged

Conversation

purplefox
Copy link
Contributor

Description

This PR exposes a bunch of Vert.x metrics including HTTP stats.

Testing done

Manually tested using jconsole.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@purplefox purplefox requested a review from a team as a code owner May 12, 2020 10:51
@purplefox purplefox requested a review from rodesai May 12, 2020 10:51
@purplefox purplefox requested a review from vcrfxia May 14, 2020 08:35
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would be great to add something about these new metrics into our docs. AFAIC all we've got currently on JMX is https://docs.ksqldb.io/en/latest/operate-and-deploy/#monitoring-and-metrics which looks rather out of date. Perhaps @JimGalasyn can comment on the best way / place to add docs.

I also ran the set of endpoints we're collecting metrics for by @rodesai so we're good to merge.

@apurvam
Copy link
Contributor

apurvam commented May 19, 2020

Should we merge this, since we are looking to cut a release soon.

@purplefox purplefox merged commit e82f762 into confluentinc:master May 21, 2020
@purplefox
Copy link
Contributor Author

Thought I merged this already! Clearly not ;)

Regarding docs - I think we can handle this external to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants