feat: drop WITH(KEY) syntax #5363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: confluentinc#3537 implements: See [KLIP-25](https://github.com/confluentinc/ksql/blob/master/design-proposals/klip-25-removal-of-with-key-syntax.md) This change removes the `WITH(KEY)` syntax which previously allowed users to specify a value column that could act as an alias for the key column. This allowed a more user friendly name to be used for the key column, at the expense of requiring a copy of the key data in the value. With the new 'any key name' feature, the key columns themselves can be given appropriate names, removing the need for this aliasing functionality. See [KLIP-25](https://github.com/confluentinc/ksql/blob/master/design-proposals/klip-25-removal-of-with-key-syntax.md) for more details.
JimGalasyn
reviewed
May 14, 2020
JimGalasyn
reviewed
May 14, 2020
JimGalasyn
reviewed
May 14, 2020
JimGalasyn
reviewed
May 14, 2020
JimGalasyn
reviewed
May 14, 2020
JimGalasyn
reviewed
May 14, 2020
JimGalasyn
reviewed
May 14, 2020
JimGalasyn
reviewed
May 14, 2020
JimGalasyn
reviewed
May 14, 2020
JimGalasyn
reviewed
May 14, 2020
JimGalasyn
reviewed
May 14, 2020
JimGalasyn
reviewed
May 14, 2020
JimGalasyn
approved these changes
May 14, 2020
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Co-authored-by: Jim Galasyn <[email protected]>
Conflicting files ksqldb-rest-app/src/test/java/io/confluent/ksql/rest/integration/LagReportingAgentFunctionalTest.java
…to remove_key_field
agavra
approved these changes
May 15, 2020
Conflicting files ksqldb-rest-app/src/test/java/io/confluent/ksql/api/integration/ApiIntegrationTest.java
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #3537
implements: See KLIP-25
This change removes the
WITH(KEY)syntax which previously allowed users to specify a value column that could act as an alias for the key column. This allowed a more user friendly name to be used for the key column, at the expense of requiring a copy of the key data in the value.With the new 'any key name' feature, the key columns themselves can be given appropriate names, removing the need for this aliasing functionality. See KLIP-25 for more details.
Reviewing notes:
Commits split to give:
TestDataProviderto not rely on key fields too, which meant changing the schema. AlsoMetastoreFixturechanged to not used key fields.Testing done
usual.
Reviewer checklist