fix: fail on WINDOW clause without matching GROUP BY #5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A WINDOW clause is only valid if there is no matching GROUP BY. Before this change, if user submitted a query without a GROUP BY it would silently be ignored, which is poor UX. With this change an helpful error message is displayed.
|
Merging without review as its minor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A WINDOW clause is only valid if there is matching GROUP BY. Before this change, if user submitted a query without a GROUP BY it would silently be ignored, which is poor UX. With this change an helpful error message is displayed.
See the QTT test for an example.
Testing done
usual
Reviewer checklist