fix: Remove stacktrace from error message #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 26, 2020 11:17
|
Requesting review from @rodesai - in cloud environments, the user doesn't have access to the server logs so there's no way for them to debug an error without some stack trace. What's the usual pattern for debugging PROD errors in cloud products outside of ksqlDB? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #5398
As a general rule servers should log internal errors but not expose internal stack traces to clients. Sending stack traces to clients can create a security risk - stack traces expose implementation details of servers - libraries used, class names, private IP, paths, etc, that can potentially be used to compromise the server or leak information that the server administrator does not want to be public.
Testing done
Updated tests
Reviewer checklist