fix: Prevent memory leaks caused by pull query logging #5532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes Pull Queries to use a fixed logger name rather than use the query id. KSQL otherwise gets OOM Errors after doing high QPS for half an hour, due to creating so many unique loggers.
This is because both in the class
io.confluent.common.logging.StructuredLoggerFactory
and in theslf4j
Logger factory itself, they keep a ConcurrentMap of name -> Logger to reuse loggers. After many, many queries, you eventually get OOMs if you create a new one every pull query.Fixes #5527
Testing done
Profiled memory before and after change.
Reviewer checklist