Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support CASE statements returning NULL #5703

Merged
merged 2 commits into from
Jun 29, 2020
Merged

fix: support CASE statements returning NULL #5703

merged 2 commits into from
Jun 29, 2020

Conversation

big-andy-coates
Copy link
Contributor

Description

fixes: #5700

Testing done

usual

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates big-andy-coates requested a review from a team as a code owner June 26, 2020 17:39
@big-andy-coates big-andy-coates added this to the 0.10.1 milestone Jun 26, 2020
@big-andy-coates big-andy-coates mentioned this pull request Jun 26, 2020
Closed
2 tasks
agavra
agavra approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Small testing gap

...tion/src/test/java/io/confluent/ksql/execution/codegen/helpers/SearchedCaseFunctionTest.java Show resolved Hide resolved
@big-andy-coates big-andy-coates merged commit 5062942 into confluentinc:6.0.x Jun 29, 2020
@big-andy-coates big-andy-coates deleted the case_fix_6 branch June 29, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agavra agavra agavra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@big-andy-coates @agavra