Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: configure topic retention based on retention clause for windowed tables #5835

Merged
merged 1 commit into from
Jul 16, 2020
Merged

fix: configure topic retention based on retention clause for windowed tables #5835

merged 1 commit into from
Jul 16, 2020

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Jul 15, 2020

Description

Fixes #5605

Previously, ksqlDB was not configuring topic retention when creating topics for windowed tables. This PR fixes that.

Testing done

Unit tests + manual.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested a review from a team as a code owner July 15, 2020 23:09
vpapavas
vpapavas approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@vpapavas vpapavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vcrfxia vcrfxia merged commit b509c99 into confluentinc:master Jul 16, 2020
@vcrfxia vcrfxia deleted the window-retention-fix branch July 16, 2020 05:14
vcrfxia added a commit to vcrfxia/ksql that referenced this pull request Jul 16, 2020
@vcrfxia
fix: configure topic retention based on retention clause for windowed…
173ec94 
… tables (confluentinc#5835)
@vcrfxia vcrfxia mentioned this pull request Jul 16, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpapavas vpapavas vpapavas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Window table retention not enforced on underlying Kafka topic
2 participants
@vcrfxia @vpapavas